fix: [df52] route timestamp timezone mismatches through spark_parquet_convert #3494
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_convert
INT96 Parquet timestamps are coerced to Timestamp(us, None) by DataFusion
but the logical schema expects Timestamp(us, Some("UTC")). The schema
adapter was routing this mismatch through Spark's Cast expression, which
incorrectly treats None-timezone values as TimestampNTZ (local time) and
applies a timezone conversion. This caused results to be shifted by the
session timezone offset (e.g., -5h45m for Asia/Kathmandu).
Route Timestamp->Timestamp mismatches through CometCastColumnExpr which
delegates to spark_parquet_convert, handling this as a metadata-only
timezone relabel without modifying the underlying values.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
CI Comparison: PR #3494 vs df52 baseline (PR #3470)
Jobs fixed by this PR (fail in #3470, pass in #3494)
Regressions introduced by this PR (pass in #3470, fail in #3494)None — every failure in #3494 also exists in #3470. SummaryThis PR is a strict improvement over the df52 baseline: 4 fewer failing CI jobs with zero regressions. Note This comment was generated with the assistance of AI (Claude Code) and should be verified independently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Timestamp(us, None)by DataFusion were being routed through Spark'sCastexpression when the logical schema expectedTimestamp(us, Some("UTC")). Spark's Cast treatsNone-timezone as TimestampNTZ (local time) and applies a timezone conversion, shifting values by the session timezone offset (e.g., -5h45m for Asia/Kathmandu)Timestamp -> Timestampmismatches throughCometCastColumnExprwhich delegates tospark_parquet_convert, handling this as a metadata-only timezone relabelTest plan
CometJoinSuiteshould now passparquet_roundtrip_int_as_string,parquet_roundtrip_unsigned_int) continue to pass🤖 Generated with Claude Code